-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.9.1 Release Proposal #5831
v5.9.1 Release Proposal #5831
Conversation
@evanlucas do you think we should include any other stages commits in this release? /cc @Fishrock123 |
Since the past two releases have meant to fix regressions while introducing new ones, I think I would prefer to keep it as is. Open to yall's thoughts though |
Since we waited until after the weekend to patch this, maybe we should do a "normal" release. Otherwise, we'll have a ton of commits next week, or another release in a day or two. |
Let's do a normal release. If you want to exclude semver-minor that is fine. |
Ok, can anyone else pick this one up? Got a pretty busy week. |
I reckon we should probably avoid single-commit releases on Stable if possible, we're more likely to get regressions on Stable and that's part of the point of pushing it out in front of LTS (and makes a little bit of a mockery of the word "Stable" but oh well). The last 3 or 4 releases have had minor regressions in them but we still had a stable roll-out. I also don't believe the vm regression is going to impact a huge number of users, so unless we do something like completely break all |
@rvagg Fair enough :] |
@evanlucas I'll take it over. |
hmm, have to do a little more today than I expected, we'll see. XD |
Branch-diff commits list:
|
577f3a2
to
d104114
Compare
I had to do like 9 conflict resolutions for this, so I want to run tests before I land any commits in v5.x. |
d104114
to
e5eb45f
Compare
e5eb45f
to
97de376
Compare
97de376
to
7e7b32b
Compare
Notable changes: * buffer: Now properly throws RangeErrors on out-of-bounds writes (Matt Loring) #5605 - This effects write{Float|Double} when the noAssert option is not used. * timers: - Returned timeout objects now have a Timeout constructor name (Jeremiah Senkpiel) #5793 - Performance of Immediate processing is now ~20-40% faster (Brian White) #4169 * vm: Fixed a contextify regression introduced in v5.9.0 (Ali Ijaz Sheikh) #5800 PR-URL: #5831
Ok screwed something up commits-wise, need to rebuild I guess. CI to make sure everything is alright: https://ci.nodejs.org/job/node-test-pull-request/2032/ I'll do the actual promotion of (new) builds and blog tomorrow.. Edit: new builds: https://ci-release.nodejs.org/job/iojs+release/480/ |
7e7b32b
to
348bf49
Compare
Notable changes: * buffer: Now properly throws RangeErrors on out-of-bounds writes (Matt Loring) #5605 - This effects write{Float|Double} when the noAssert option is not used. * timers: - Returned timeout objects now have a Timeout constructor name (Jeremiah Senkpiel) #5793 - Performance of Immediate processing is now ~20-40% faster (Brian White) #4169 * vm: Fixed a contextify regression introduced in v5.9.0 (Ali Ijaz Sheikh) #5800 PR-URL: #5831
Notable changes: * buffer: Now properly throws RangeErrors on out-of-bounds writes (Matt Loring) #5605 - This effects write{Float|Double} when the noAssert option is not used. * timers: - Returned timeout objects now have a Timeout constructor name (Jeremiah Senkpiel) #5793 - Performance of Immediate processing is now ~20-40% faster (Brian White) #4169 * vm: Fixed a contextify regression introduced in v5.9.0 (Ali Ijaz Sheikh) #5800 PR-URL: #5831
PR-URL: #5831
348bf49
to
90c2063
Compare
Ok I'm not sure what happened with my branches, but anyways I'm updating the date and running the CI jobs again. CI: https://ci.nodejs.org/job/node-test-pull-request/2043/ |
Notable changes: * buffer: Now properly throws RangeErrors on out-of-bounds writes (Matt Loring) nodejs#5605 - This effects write{Float|Double} when the noAssert option is not used. * timers: - Returned timeout objects now have a Timeout constructor name (Jeremiah Senkpiel) nodejs#5793 - Performance of Immediate processing is now ~20-40% faster (Brian White) nodejs#4169 * vm: Fixed a contextify regression introduced in v5.9.0 (Ali Ijaz Sheikh) nodejs#5800 PR-URL: nodejs#5831
v5.9.1 Release Proposal
Notable changes:
Sheikh) Backport 5786 to v5.x #5800
Commits:
c5d83695e1
] - contextify: tie lifetimes of context & sandbox (Ali Ijaz Sheikh) #5800